Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Auto register for types #61

Closed
antfu opened this issue Oct 9, 2021 · 12 comments · Fixed by unjs/unimport#218
Closed

RFC: Auto register for types #61

antfu opened this issue Oct 9, 2021 · 12 comments · Fixed by unjs/unimport#218
Labels
enhancement New feature or request help wanted Extra attention is needed pr welcome

Comments

@antfu
Copy link
Member

antfu commented Oct 9, 2021

Context:

For example, it would be great to have common types like Ref, ComputedRef globally available when using the Vue preset. I would expect the API to be like

{
  // auto importing for import
  imports: [
    'vue'
  ],
  // auto importing for types
  types: [
    'vue', // again, we could have presets for it.
    {
      vue: ['Ref', 'ComputedRef']
    }
  ]
}
@antfu antfu added enhancement New feature or request help wanted Extra attention is needed pr welcome labels Oct 9, 2021
@antfu antfu changed the title Auto register for Types RFC: Auto register for types Oct 9, 2021
@antfu antfu pinned this issue Oct 9, 2021
@userquin
Copy link
Member

userquin commented Oct 10, 2021

@antfu

Created new branch feat/auto-register-global-types:

  • added types and split resolvedImports on TransformOptions (now has imports and types) on src/types.ts: added also some new stuff to support global types
  • created pickTypes helper function, it is exported on each unplugin to allow import partial preset types or full preset: you can see on playground vite.config.ts file with partial preset for vue using Ref and ComputedRef on HelloWorld sfc
  • added global types for vue, vue-demi, @vue/composition-api, pinia and vuex: we need to review them, maybe I forgot some types/interfaces
  • updated core to handle changes made to the types: with no breaking changes

You can find global types presets stuff on src/global-types directory.

There are some // todo@userquin comments on src/core modules, take a look when you've time.

EDIT: maybe there is a breaking change if someone is using the resolvedImports from TransformOptions.

@userquin
Copy link
Member

userquin commented Oct 10, 2021

Right now I include global types on d.ts file using:

// Generated by 'unplugin-auto-import'
// We suggest you to commit this file into source control
import type {
  ComputedRef as __ComputedRef,
  Ref as __Ref  
} from 'vue'

declare global {
  type ComputedRef<T> = __ComputedRef<T>
  type Ref<T> = __Ref<T>
  const computed: typeof import('vue')['computed']
  ...
}
export{}

maybe we can use this another approach as suggested on issue on vue-global-api repo (both approaches work in IntelliJ, this latter would simplify the logic to generate the d.ts file and avoid adding redundant imports):

// Generated by 'unplugin-auto-import'
// We suggest you to commit this file into source control
declare global {
  type ComputedRef<T> = import('vue').ComputedRef<T>
  type Ref<T> = import('vue').Ref<T>
  const computed: typeof import('vue')['computed']
  ...
}
export {}

@userquin
Copy link
Member

userquin commented Oct 11, 2021

Current approach on IntelliJ:

image

With suggested approach on vue-global-api repo on IntelliJ:

image

@userquin
Copy link
Member

Pushed some changes:

  • revert changing resolvedImports, included resolvedTypes on TransformOptions
  • use import also for types on dts generation
  • added pinia, vuex and svelte types

@jrson83
Copy link

jrson83 commented Jun 1, 2022

Will you release a npm package with integrated #118 soon?

@antfu
Copy link
Member Author

antfu commented Aug 8, 2022

It's not yet possible to have a .d.ts redirecting a type from another module.

https://stackblitz.com/edit/node-jjgj6g?file=index.ts

I'd consider it as a limitation of TypeScript. If anyone finds a solution, please comment with a fork of the Stackblitz playground and then we could discuss how to implement that. Thanks.

@ennioVisco
Copy link

According to this: https://gist.github.com/Bnaya/97080f563fa8242e26a041732185a260 it depends to some typescript flag that can (and perhaps should) be disabled?

@terran42
Copy link

@antfu Maybe I misunderstood, but is this not what you want?

Both seems to work, at least to my needs:

  • Ref<number> in index.ts has hint type Ref<T> = Ref<any>
  • Cmd+Click directs me to the right place in imports.d.ts or global.d.ts
  • Cmd+Click in imports.d.ts or global.d.ts on V.Ref or import('vue').Ref leads to definitions in Vue.

I'm happy with that.

@KeyToLove
Copy link

It's not yet possible to have a .d.ts redirecting a type from another module.

https://stackblitz.com/edit/node-jjgj6g?file=index.ts

I'd consider it as a limitation of TypeScript. If anyone finds a solution, please comment with a fork of the Stackblitz playground and then we could discuss how to implement that. Thanks.

也就是说现阶段想使用依赖的interface或其它类型定义(e.g: Ref),依旧需要通过显示引入的方式么🤔️

@antfu
Copy link
Member Author

antfu commented Nov 16, 2022

@terran42 Thanks for trying. But your solution seems to throw away the generics and make them any. I think it's not good enough.

@MKraust
Copy link

MKraust commented Jan 28, 2023

@antfu TypeScript 5.0 introduces export type * from '...'. Stable release is scheduled to March 14th.
https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#support-for-export-type

Any chances that type auto-imports could be implemented in the near future after TS 5.0 release?

@LukerSpringtree
Copy link

dirs 配置的目标文件 中的类型 怎么自动导出

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed pr welcome
Projects
None yet
8 participants