Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: For some odd reason screenreaders don't see the list of projects #2768

Open
zersiax opened this issue Jun 16, 2021 · 9 comments
Labels
discussion open-ended issues that haven't yet defined what needs to be worked on has questions Reviewer has outstanding questions about the pull request

Comments

@zersiax
Copy link

zersiax commented Jun 16, 2021

Just had a super quick look at this page and something odd appears to be happening.
The entire projects section between the " Projects" h1 and the "I want to get involved" h1 is just completely invisible for screenreader users.
I see the elements in the DOM tree, but something is making the screenreader think that part is not actually part of the DOM. The usual suspect is an errand aria-hidden somewhere, which I didn't immediately see in the code, or a display: none that can only be removed by clicking an icon that isn't visible to screenreader users. I didn't immediately see that either, not on the entire div that is.
Any clue what might be happening here? Is the project list collapsed by default, visually speaking? (can't check, blind developer myself :) )

@genderplugin
Copy link

Hi!

I am using the NVDA screenreader and everything seems to still be working fine. Is this still an issue for you?

@zersiax
Copy link
Author

zersiax commented Jun 28, 2021

Hmm. No, or well ...not in Firefox, but yes in Chrome and Edge, where I have adblockers running.
I see an error in the console abou google analytics erroring out, might that be why?

@ritwik12
Copy link
Collaborator

@zersiax Did you tried without Adblockers? This should not be an issue as we are not serving ads. Maybe your ad blocker is blocking even google analytics.

@ritwik12
Copy link
Collaborator

ritwik12 commented Jun 28, 2021

visually speaking? (can't check, blind developer myself :) )

@zersiax I am really impressed to see that you are contributing to Open Source. if you are a beginner or need any help. Feel free to pop a mail to me anytime. Would be happy to help :)

@zersiax
Copy link
Author

zersiax commented Jun 28, 2021

Looks like tracker_prevention settings in the browser are blocking Google Analytics ...which makes sense, given GA is a tracker :)
Might be that GA is in the minified JS before the list of filters gets loaded, that would probably cause this behavior :)

@ritwik12
Copy link
Collaborator

@zersiax Thanks for taking a look. From what I can see in _includes/scripts.html at https://github.com/up-for-grabs/up-for-grabs.net/blob/gh-pages/_includes/scripts.html. The GA is mentioned at the last only.

@genderplugin
Copy link

@ritwik12 sorry to hop on but could I send you an email as well? having trouble finding a good first issue to tackle and would love some tips.

@ritwik12
Copy link
Collaborator

@ethanstarcher Sure, I was thinking of taking your name also. Please let me know if I can help you.

@ritwik12 ritwik12 added discussion open-ended issues that haven't yet defined what needs to be worked on has questions Reviewer has outstanding questions about the pull request labels Jul 14, 2021
@mervy93
Copy link

mervy93 commented Oct 15, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion open-ended issues that haven't yet defined what needs to be worked on has questions Reviewer has outstanding questions about the pull request
Projects
None yet
Development

No branches or pull requests

4 participants