Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon Not Visible in Browser Dark Mode #3611

Open
solomonsanderson opened this issue Nov 16, 2022 · 20 comments
Open

Favicon Not Visible in Browser Dark Mode #3611

solomonsanderson opened this issue Nov 16, 2022 · 20 comments

Comments

@solomonsanderson
Copy link

I have seen issues #3026 and #3545 which mention a new logo, none of these mention the favicon. This appears simply as a circle when using dark mode in chrome.

@dinesh671
Copy link

dinesh671 commented Nov 18, 2022

hey there we need to create two different icons for dark and light mode and we need to use some attributes to use the icons dynamically so that we can appropriate icons for there themes. i would like work on it could please assign this issue for me

@enricozz
Copy link

I made some icons:

Home Screen -
logo

Favicon -
favicon-source

@c9ssio
Copy link
Contributor

c9ssio commented Nov 24, 2022

I just added this new favicon, but why so many favicons with different sizes?

@dinesh671
Copy link

after creating different icons, call this icons in the html page with to different link tags, and then add the media="(prefers-color-scheme: dark)" and media="(prefers-color-scheme: light)"

@dinesh671
Copy link

hey actually the problem is we need to create a new logo for dark mode. the logo should be have #58585A color filled arm and #FFFFFF color of stroke. creating this type of logo the gray fill will be invisible in dark mode and the white stroke in dark mode will be visible as we can see currently a small circle is visible by adding this icon with that attributes mentioned in before comment we can solve this issue

@dinesh671
Copy link

hey you know what i got new simple solution just add the white background to the favicon then it will look good

@solomonsanderson
Copy link
Author

@dinesh671 Which .html file do you think this should be added to?

add the media="(prefers-color-scheme: dark)" and media="(prefers-color-scheme: light)"

@dinesh671
Copy link

dinesh671 commented Nov 24, 2022

i think in head.html @solomonsanderson

@mickey097
Copy link

mickey097 commented Nov 24, 2022 via email

@neuralpain
Copy link

Is this issue open or closed? If closed then #3026 and #3545 should be closed as well, no?

@ritwik12
Copy link
Collaborator

@solomonsanderson Is this still valid after #3546?

@dinesh671
Copy link

@ritwik12 as you have added the logo that doesn't solved the issue fav-icon is not visible

@munnokd
Copy link

munnokd commented Apr 20, 2023

Hey @dinesh671 can I work on this issue?

@dinesh671
Copy link

hey @munnokd I am not the admin of the group please ask @mickey097 I am also waiting for his reply

@munnokd
Copy link

munnokd commented Apr 21, 2023

@mickey097 Can you assign this issue to me?

@MehmetTerc
Copy link

Can you assign this issue to me?

@Diegogonzalez1008
Copy link

Wtf are we doing explain please

@Diegogonzalez1008
Copy link

I need money

@Sam10-debug
Copy link

Hello, can this issue be assigned to me

@Shashankpantiitbhilai
Copy link

please assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

13 participants