New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ESLint plugin deduplication #110
Comments
Potentially if we switch to We could then get rid of this logic in the install script: eslint-config-upleveled/bin/install.js Lines 40 to 72 in db6e25a
|
Leaving this open until the Yarn logic above is removed |
karlhorky
added a commit
that referenced
this issue
Apr 3, 2023
pnpm v8 enables auto-install-peers by default and this should automatically install a lot of the dependencies which we have been manually copying from the config's peerDependencies to the project's devDependencies Ref: https://pnpm.io/npmrc#auto-install-peers Closes #110 Closes #212
karlhorky
added a commit
that referenced
this issue
Apr 3, 2023
* Remove Yarn installation instructions * Remove Yarn support, rely on auto-install-peers pnpm v8 enables auto-install-peers by default and this should automatically install a lot of the dependencies which we have been manually copying from the config's peerDependencies to the project's devDependencies Ref: https://pnpm.io/npmrc#auto-install-peers Closes #110 Closes #212
karlhorky
added a commit
that referenced
this issue
May 5, 2023
Our extension of the eslint-config-react-app has always caused problems: 1. Conflicts between versions of plugins 2. Unnecessary ESLint plugins being installed eg. jest and flowtype We have worked around 1. with solutions such as Yarn resolutions and moving to pnpm with auto-install-peers=true: #110 Since create-react-app is going away, eslint-config-react-app will likely not be maintained any longer (it has not received any updates for 2 years). This commit absorbs the contents of eslint-config-react-app into our own config, where we will maintain it from now on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Review options for simpler deduplication than Yarn Resolutions:
"dependencies"
inside shared configs (where is the reference proving this?)The text was updated successfully, but these errors were encountered: