Switch to ESLint Flat Config #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
karlhorky
commented
Nov 11, 2023
| @@ -1,4 +1,18 @@ | |||
| /** @type {import('@typescript-eslint/utils').TSESLint.Linter.RuleLevelAndOptions} */ | |||
There was a problem hiding this comment.
actually would prefer to keep using the typescript-eslint types, but the FlatConfig types are not published yet, so work around this temporarily:
karlhorky
changed the title
karlhorky
commented
Nov 11, 2023
Comment on lines
+502
to
+508
| settings: { | ||
| 'import/resolver': { | ||
| // Load <rootdir>/tsconfig.json | ||
| typescript: { | ||
| // Always try resolving any corresponding @types/* folders | ||
| alwaysTryTypes: true, | ||
| }, |
There was a problem hiding this comment.
this is also ok in the new Flat Config format
karlhorky
commented
Nov 11, 2023
| { | ||
| // Lint common extensions by default with rules above | ||
| files: [ | ||
| '**/*.js', |
There was a problem hiding this comment.
had to add **/*.js here - otherwise .js files would not be linted
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
karlhorky
added a commit
to upleveled/create-react-app
that referenced
this pull request
Nov 12, 2023
"type": "module" in package.json usually causes webpack to require a fully-specified import path including .js - https://webpack.js.org/configuration/module/#resolvefullyspecified We require "type": "module" in package.json because ESLint we want to use ESM syntax in our eslint.config.js file and ESLint does not support other ways of specifying that the config file is ESM such as an .mjs extension: - eslint/eslint#13440 - eslint/eslint#16580 This is a part of the switch to the ESLint Flat Config being done here: - upleveled/eslint-config-upleveled#301
karlhorky
added a commit
to upleveled/preflight-test-project-react-passing
that referenced
this pull request
Nov 12, 2023
Closed
gruvector
pushed a commit
to gruvector/preflight-test-project
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #160
Convert to new ESLint Flat Config by following resources such as:
azat-io/eslint-confighttps://github.com/azat-io/eslint-configJP-Ellis/jpellis.mehttps://github.com/JP-Ellis/jpellis.me/blob/main/eslint.config.jsTODO
@upleveled/create-react-app