-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][CUSTOM WIDTH] Custom width calculates wrong height, causing images to be stretched to the right #794
Comments
Seems like there's an issue with height calculation. It's calculating the height as 1020x1465275732, which is why it's unable to write. |
I'd suggest using just the scale for now. I'll push a new update for custom width later. |
Also strange that it never actually calculates the height, otherwise it would have given an output. |
@StScAllen Could you please share the image if possible? I am unable to reproduce the error. |
I started using upscayl today, and I am having the exact same issue. I am trying to increase the image from 870x870 to 4500x4500. (I would share the image but my company won't allow it.) I'm glad there is an update planned to fix it, thanks. |
FYI - If you uninstall 2.11 and download and install 2.10 it will work fine. Nice changes in 2.11 but rolling back to 2.10 is not critical. |
Understood. Thank you for the tips. |
@StScAllen I'm unable to reproduce this issue on Mac: |
@aaronliu0130 the images don't stretch, they get corrupted. It takes int's upper value as the height for some strange reason. |
That may be the cause, but the visual effect in #794 (comment) (and in my testing) is that the image gets striated and stretched to the right. |
Hi, I just wanted to confirm what xvim64 commented. Either no output or distorded. The height is wrong. A 768x768 image that I try to upscale to 4k is becoming a 4096x628. ;-( Just wanted to say that your program is still really nice though. Having the custom width working would be so sweeeeeet! |
Upscayl NCNN has received the hotfix. If you want to fix it in Upscayl right now, here's what you can do:
This should hopefully fix all issues with the custom width 😄 |
The hotfix works well on Windows 11 23H2. |
Since the hotfix works, we should probably release a 2.11.1. |
Ok, will do! |
Legendary. Just confirming it's also fixed a bug for me where custom width images weren't saving. Now custom width images are working as expected. Thank you so much <3 |
Thanks for hotfix |
Checklist
Describe the Bug
Using the Custom Width scale setting on version 2.11 I get an Unable to Write to output directory error. This ONLY occurs when using custom width, using a preset scaling works fine.
To Reproduce
Upscayl Version (or commit hash)
2.11
Platform
Windows
OS Version
Windows 11
GPU Name
Nvidia Geforce RTX 4070 TI SUPER
Expected Behavior
Image will be upscaled to custom width setting and write the output to disk without error.
Screenshots
No response
Logs
The text was updated successfully, but these errors were encountered: