Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for retry merge-gatekeeper failure #41

Open
aradwyr opened this issue Oct 4, 2022 · 3 comments
Open

Add support for retry merge-gatekeeper failure #41

aradwyr opened this issue Oct 4, 2022 · 3 comments

Comments

@aradwyr
Copy link

aradwyr commented Oct 4, 2022

It'd be helpful to be able to retry in the event of a merge-gatekeeper failure

@rytswd
Copy link
Member

rytswd commented Oct 4, 2022

Hi @aradwyr, thanks for filing an issue! ☺️

Could you please elaborate what you mean by "merge-gatekeeper failure"? Merge Gatekeeper does simple polling for the predefined timeout duration (default set to 600 sec), and if it exceeds that it goes to the failure state. If some jobs took longer than 10 min, you can simply rerun Merge Gatekeeper job - do you mean to get some other control for such a rerun?

@muratkeremozcan
Copy link

Hi @aradwyr, thanks for filing an issue! ☺️

Could you please elaborate what you mean by "merge-gatekeeper failure"? Merge Gatekeeper does simple polling for the predefined timeout duration (default set to 600 sec), and if it exceeds that it goes to the failure state. If some jobs took longer than 10 min, you can simply rerun Merge Gatekeeper job - do you mean to get some other control for such a rerun?

If we retry a failing job (terrible practice, but zealously worshipped by engineers) , that job passes, and we rerun merge gatekeeper, merge gatekeeper will still pick on the failing job although now it passes.

The solution becomes git commit --allow-empty -n -m "rerun" && git push .

@aradwyr
Copy link
Author

aradwyr commented May 25, 2024

@markrmullan maybe you can forward this to the right person since I've left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants