Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: lib/plugins: make sure required attributes are set #338

Open
bcoles opened this issue Oct 3, 2020 · 0 comments
Open

TODO: lib/plugins: make sure required attributes are set #338

bcoles opened this issue Oct 3, 2020 · 0 comments

Comments

@bcoles
Copy link
Collaborator

bcoles commented Oct 3, 2020

  def self.define(&block)
    # TODO: plugins should isolated
    p = new
    p.instance_eval(&block)
    p.startup
    # TODO: make sure required attributes are set
    Plugin.attributes.each { |symbol| p.instance_variable_get("@#{symbol}").freeze }
    Plugin.registered_plugins[p.name] = p
  end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant