Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation via Brew for Mac Users #401

Open
oregonpillow opened this issue Aug 24, 2023 · 2 comments
Open

Installation via Brew for Mac Users #401

oregonpillow opened this issue Aug 24, 2023 · 2 comments

Comments

@oregonpillow
Copy link

Hi,
before i proceed with this, i checked that no brew formula currently exists for whatweb and that the GPLv2 license would permit it to be uploaded to the brew package manager.

Is there a reason why up until now whatweb has not been offered as a brew package? If there's no objection I will try to create a brew formula for whatweb

@urbanadventurer
Copy link
Owner

urbanadventurer commented Aug 26, 2023 via email

@oregonpillow
Copy link
Author

oregonpillow commented Aug 28, 2023

Homebrew/homebrew-core#140724

First Brew pull but there is still the problem with the Ruby version for older macos versions. I actually tested on Monterey and i experience the same problem you mentioned for Catlina .

The fix is easy for Brew in practice, I just tell it to install a newer (adjacent) Ruby version (using Brew) for builds on Monterey or older and it works. The problem is that Brew is insistent on this being a bad practice, and despite the build being successful and working, it will fail CI tests or when I run brew audit --new-formula whatweb. I'll have to wait for their maintainers to recommend best action to take.

Regarding my Brew test, I'm not experienced with Ruby and any suggestions for a better test for basic app functionality when you run brew test whatweb would be highly welcome. Ideally integrating some of the existing unit tests you've already written might be good. But for now, just want to get something submitted and the only test i provided was checking the whatweb --version is expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants