Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot .bin files should contain metadata #460

Open
matthew-levan opened this issue Jun 15, 2023 · 2 comments
Open

snapshot .bin files should contain metadata #460

matthew-levan opened this issue Jun 15, 2023 · 2 comments
Assignees
Labels
feature New feature or feature request

Comments

@matthew-levan
Copy link
Contributor

matthew-levan commented Jun 15, 2023

In order to prevent the need to load entire snapshots just to extract metadata (like eve_d, for example), the files should just start with a magic number identifying itself as an Urbit snapshot followed by some metadata. The epoch system might be a good place to add this to our files.

Related #346.

@matthew-levan matthew-levan added the feature New feature or feature request label Jun 15, 2023
@belisarius222
Copy link
Contributor

I'm thinking it should include a Vere version number, specifically.

@joemfb
Copy link
Member

joemfb commented Jun 15, 2023

There is a metadata, and it has its own version number. We chose to load the snapshot in the standard way (thereby applying any outstanding patch files), rather than add a code path for reading granularly. But that could be revisited...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

4 participants