Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate desk names from Clay effects #610

Open
tiller-tolbus opened this issue Feb 21, 2024 · 1 comment · May be fixed by #650
Open

Validate desk names from Clay effects #610

tiller-tolbus opened this issue Feb 21, 2024 · 1 comment · May be fixed by #650

Comments

@tiller-tolbus
Copy link

Per convo with @joemfb, unix.c is not guaranteed to prevent disastrous outcomes from malformed %ergo effects coming from Clay, such as attempts to write to .urb or .run.

Desired case is that there is, at least, a hard-coded and unified list of paths that Vere will not write to as the result of a Clay effect.

Such a unified list of paths should also include a .host directory so that providers have a safe place to put pier-specific files that won't be touched by the runtime.

@joemfb
Copy link
Member

joemfb commented Feb 21, 2024

Rather than an explicit whitelist, ensuring that clay mountpoint names (ie, desks) conform to (sane %tas) is probably the simplest way to accomplish this. That would need to be done in each of the desk-relevant effect handlers in unix.c: u3_unix_ef_ergo(), u3_unix_ef_ogre(), u3_unix_ef_*() ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants