New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.14 #1085
go 1.14 #1085
Conversation
@@ -39,7 +39,7 @@ jobs: | |||
ref: ${{ github.ref }} | |||
|
|||
- name: GOFMT Check | |||
if: matrix.go == 1.13 && matrix.os == 'ubuntu-latest' | |||
if: matrix.go == 1.14 && matrix.os == 'ubuntu-latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At someone point someone should change this to go-latest
🙂
@@ -19,9 +19,9 @@ Usage documentation exists for each major version. Don't know what version you'r | |||
|
|||
## Installation | |||
|
|||
Make sure you have a working Go environment. Go version 1.11+ is supported. [See the install instructions for Go](http://golang.org/doc/install.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this line when originally making this PR, so I removed the go 1.11 reference here!
|
||
Go Modules are strongly recommended when using this package. [See the go blog guide on using Go Modules](https://blog.golang.org/using-go-modules). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go modules are production ready now, I think it's safe to make this statement stronger
@@ -63,4 +63,4 @@ export PATH=$PATH:$GOPATH/bin | |||
|
|||
cli is tested against multiple versions of Go on Linux, and against the latest | |||
released version of Go on OS X and Windows. This project uses Github Actions for | |||
builds. For more build info, please look at the [./.github/workflows/cli.yml](https://github.com/urfave/cli/blob/master/.github/workflows/cli.yml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to explicitly mention that you can look at the ci config for go version testing info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What type of PR is this?
What this PR does / why we need it:
Updates our go version testing to include go 1.14, and drops go 1.11 testing.
Context
go 1.14 has released and I'm continuing the existing pattern of supporting 3 go versions. I'm not 100% sure when this pattern was started, but I assume it's fine to continue it.