fix(zsh_autocomplete): List files on tab with no completion options #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will simply list the files in the current directory if there are no auto-completion options available. With this change, the zsh auto-completion will align with the functionality in the bash auto-completion file provided. New functionality: https://asciinema.org/a/EAYRIEVGTGNSS2gCGwSJ4Zw1i Old functionality: https://asciinema.org/a/BfOZz4BHUGwjXMFptbmDHZocH Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
oleorhagen
requested review from
coilysiren and
asahasrabuddhe
and removed request for
a team
coilysiren
approved these changes
May 4, 2020
Yup, some tests for the auto-completion features (both bash and zsh) would have been nice. But I didn't see any in place as of now. I wonder how much effort it would be to bootstrap? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Aligns zsh auto-completion functionality with the bash auto-completion
Which issue(s) this PR fixes:
Special notes for your reviewer:
Testing
Tested manually
New functionality: https://asciinema.org/a/EAYRIEVGTGNSS2gCGwSJ4Zw1i
Old functionality: https://asciinema.org/a/BfOZz4BHUGwjXMFptbmDHZocH
Release Notes
(REQUIRED)