Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport zsh_autocomplete from master to the v1 branch #1133

Merged
merged 1 commit into from May 8, 2020

Conversation

oleorhagen
Copy link
Contributor

What type of PR is this?

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

Backports the autocomplete/zsh_autocomplete file from master to v1 as there is nothing keeping these files from being mirrored.

Which issue(s) this PR fixes:

No open issues for this.

Testing

This is tested locally, and the auto-completion scripts have no tests at the moment.

Release Notes

(REQUIRED)

Backported the ZSH auto-completion script from master in order to:
* list files if no completions are present.
* auto-complete flags

Some bug fixes have been added to master for the zsh_autocomplete function.
Backport this to make it available for v1 also.

Changelog: None

Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
@oleorhagen oleorhagen requested a review from a team as a code owner May 5, 2020 08:38
@oleorhagen oleorhagen requested review from rliebz and coilysiren and removed request for a team May 5, 2020 08:38
@oleorhagen oleorhagen changed the base branch from master to v1 May 5, 2020 08:39
Copy link
Member

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why CI is failing, can you re-request my review after you've look into that?

Also, v1 is intended to be in maintenance mode and isn't meant for getting new features. This is an ok exception since it's a simple change, but in general if you want new features then you need to migrate to v2.

@oleorhagen
Copy link
Contributor Author

I'm not sure why CI is failing, can you re-request my review after you've look into that?

Also, v1 is intended to be in maintenance mode and isn't meant for getting new features. This is an ok exception since it's a simple change, but in general if you want new features then you need to migrate to v2.

Thank you @lynncyrin.

Yes, I understand the release cycle for semantic versioning. However, for some enterprise software the cycles can be loooong, thus we are stuck on v1 for some time still.

Also, I would not consider this a feature, but a fix, considering, what it is really doing is porting the buf-fixes from the auto-complete script in v2.

However, this is all up to you, on how you guys want to handle this :)

Thank you for a nice CLI library!

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants