New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added manual and script for PowerShell autocomplete #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I have no knowledge about the PowerShell. :)
Any updates? Or anything I need to improve before it can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Oh, @kirinnee the docs tests are failing b/c you're missing a heading. Check the logs here => https://github.com/urfave/cli/pull/1139/checks?check_run_id=683967954 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echoing my last comment, you'll need to add PowerShell Support
to the table of contents! Please do re-request me when you've done that 👍
Hi I have updated accordingly. Please lmk if there are more changes needed! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else. |
Any updates? |
This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What this PR does / why we need it:
This adds documentation and script to enable autocomplete on both
PowerShell and PS Core on Windows (and other platforms)
Special notes for your reviewer:
Not sure how to automate testing
Testing
Following instructions added to the manual in a PowerShell environment