Allow using Value with TimestampFlag #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vschettino
requested review from
saschagrunert and
coilysiren
and removed request for
a team
rliebz
approved these changes
Jul 12, 2020
|
Would there be a new release for this fix? |
|
Someone would have to create a new release, I don't know offhand if anyone is currently planning to do so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Allows to use default Value with TimestampFlags.
Which issue(s) this PR fixes:
fixes #1144
Special notes for your reviewer:
Thanks @aloababa for the tip!
cc @lynncyrin
Testing
Just a small unit test to check if setting a Value will led to a filled parameter when there is no cli input.
Release Notes