Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add a App.Reader that defaults to os.Stdin #1191

Merged
merged 1 commit into from Oct 22, 2020
Merged

feature: Add a App.Reader that defaults to os.Stdin #1191

merged 1 commit into from Oct 22, 2020

Conversation

stellirin
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

  1. Add a new default Reader to the App for easy testing STDIN.
  2. Adds tests for the above.

Which issue(s) this PR fixes:

(REQUIRED)

Closes: #1190

Release Notes

(REQUIRED)

Add a App.Reader that defaults to os.Stdin.

@stellirin stellirin requested a review from a team as a code owner October 2, 2020 10:45
@stellirin stellirin requested review from saschagrunert and rliebz and removed request for a team October 2, 2020 10:45
saschagrunert
saschagrunert approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimothyStiles
Copy link

I've been searching hours for a nice solution for testing stdin like this. Is there anyway I can help get it merged?

@rliebz rliebz merged commit 30bb698 into urfave:master Oct 22, 2020
@TimothyStiles
Copy link

Thanks @rliebz for merging that and thanks @stellirin for writing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@rliebz rliebz rliebz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2 feature: Add a App.Reader that defaults to os.Stdin
4 participants
@stellirin @TimothyStiles @saschagrunert @rliebz