Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pre-request scripts operate on completely prepared request #2250

Conversation

pietrygamat
Copy link
Contributor

@pietrygamat pietrygamat commented May 6, 2024

Description

The pre-request script phase is now executed after configureRequest. That means the 'req' object in pre-request script has access to more data, including evaluated variables, set authorization headers, etc.

fixes #2249

Makes sense especially if #2061 / #2077 are to be accepted, because this would allow to access OAuth2 credentials after they are obtained, but before sending actual user request.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

The pre-request script phase is now executed after configureRequest. That means the
'req' object in pre-request script has access to more data, including evaluated variables, set authorization headers, etc.

fixes usebruno#2249
@pietrygamat pietrygamat deleted the bugfix/prerequest-after-configure branch May 28, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Pre-request script is executed before the request is prepared
1 participant