Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create helper tests for in-progress image PRs #657

Open
tobybellwood opened this issue Jan 7, 2023 · 0 comments
Open

create helper tests for in-progress image PRs #657

tobybellwood opened this issue Jan 7, 2023 · 0 comments
Assignees

Comments

@tobybellwood
Copy link
Member

tobybellwood commented Jan 7, 2023

we've got in-progress PRs for mysql (#308) and dotnet (#550)

Neither of these images has a set of tests in the helper docker-compose stack. We should update each by adding it's images to the docker-compose, and then creating the additional tests - for MySQL, they can be similar to mariadb (although that may require some work with uselagoon/internal-services-test to support MySQL), and for dotnet, maybe there's a one-liner we can use to spin up a webserver (similar to python, node and ruby)

Note that these images are still a WIP, so can be changed if needed to support this.

(note, to test locally, replace the image: uselagoon/dotnet-6.0:latest with lagoon/dotnet-6.0:latest in the docker-compose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants