Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis MAXMEMORY should be clamped #952

Open
smlx opened this issue Mar 18, 2024 · 3 comments
Open

Redis MAXMEMORY should be clamped #952

smlx opened this issue Mar 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@smlx
Copy link
Member

smlx commented Mar 18, 2024

Suggest 100Mi min to 2Gi max.

Making this value too large can cause site and cluster stability problems.

@smlx smlx added the enhancement New feature or request label Mar 18, 2024
@smlx smlx changed the title Redis MAXMEMORY should be limited Redis MAXMEMORY should be clamped Mar 18, 2024
@tobybellwood
Copy link
Member

Any prior art on how we could constrain this in an entrypoint - I can see lots of bash loops 🙈 - but maybe a tiny binary may work better and be reusable!

@smlx
Copy link
Member Author

smlx commented Mar 18, 2024

Maybe the logic should not be in an entrypoint but instead in the build-deploy tool? Bash for this kind of arithmetic is just painful.

@shreddedbacon
Copy link
Member

Unfortunately, we can't control this value in a build if someone injects it via a .env or .lagoon.env based file, or if they code it in a Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants