fix: use correct stop signal in php cli for faster termination #989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sleep script in the commons image checks for the
SIGTERM
signal, but the php-cli images specifySIGQUIT
which causes unnecessary delay in termination. This PR sets the correct signal for php-cli images.Tested locally with docker-compose. Before it would wait up to 20 seconds for the
cli
to terminate, after it is practically instant.Closes #976.