Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition remotecommand from SPDY to Websockets once support is widely available #407

Open
smlx opened this issue Mar 1, 2024 · 0 comments
Open

Transition remotecommand from SPDY to Websockets once support is widely available #407

smlx opened this issue Mar 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@smlx
Copy link
Member

smlx commented Mar 1, 2024

Upstream k8s is moving from the deprecated SPDY protocol to Websockets. See kubernetes/enhancements#4006

Once that happens (and support is rolled out more widely), we'll need to update ssh-portal to use the websockets protocol for remotecommand actions. See e.g. https://github.com/uselagoon/lagoon-ssh-portal/blob/main/internal/k8s/exec.go#L187
@smlx smlx added the enhancement New feature or request label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smlx