Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect the build controller to the topologically-closest docker-host #239

Open
tobybellwood opened this issue Nov 28, 2023 · 3 comments
Open

Comments

@tobybellwood
Copy link
Member

In a scenario where there are N docker-hosts in N zones, the remote-controller should be able to provide a build pod with the connection details for it's closest docker-host. The build will then use that docker-host for the duration of it's build.

@shreddedbacon shreddedbacon changed the title Coinnect the build controller to the topologically-closest docker-host Connect the build controller to the topologically-closest docker-host Nov 28, 2023
@shreddedbacon
Copy link
Member

shreddedbacon commented Mar 5, 2024

Since we know that the topology aware hints stuff doesn't really work, we can reject that. I don't think we will have an easy way to properly do topologically closest docker-hosts.

Alternatively though, we could have the remote-controller scan for kind: Service within a cluster that have a specific label (eg app.kubernetes.io/component=lagoon-remote-docker-host) to determine if there are 1 or more docker-hosts within a cluster. Or we can define custom labels to use to select docker-hosts too.

When the controller is creating the build pods, it can just round robin them amongst the known docker-hosts by injecting the docker-host record into a build, rather than the builds defaulting to docker-host.lagoon.svc, that can be a fallback.

@tobybellwood
Copy link
Member Author

I still think it may be worth trying to identify the "closest" zone-based (per labels) docker-host and allocating that to a build in this scenario, but round-robining if necessary (overload or unavailablility)

@shreddedbacon
Copy link
Member

I still think it may be worth trying to identify the "closest" zone-based (per labels) docker-host and allocating that to a build in this scenario, but round-robining if necessary (overload or unavailablility)

The main problem though, is that the controller doesn't schedule the builds, and there is no easy way for a build pod to identify which zone it is in to know which to choose from, but agree, if it is possible to solve this without the remote-controller having to handle scheduling too, then that would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants