Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rootless builds #36

Open
smlx opened this issue Feb 5, 2021 · 1 comment
Open

Rootless builds #36

smlx opened this issue Feb 5, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@smlx
Copy link
Member

smlx commented Feb 5, 2021

While working on uselagoon/lagoon#2481 I noticed that the build pods are running as root. I just wanted to start a discussion about the best way to update them to run as a non-root user.

Do you see any issues with running as a different user? And where would be the best place to define a securityContext on the build pod? Hard-coding it in lagoon-kbd would be one way.. but is that the best way to go?

@smlx smlx added the enhancement New feature or request label Feb 5, 2021
@shreddedbacon
Copy link
Member

shreddedbacon commented Feb 8, 2021

I don't think there would be any issues running builds as a different user for the majority of the build. The only thing that could be an issue is being able to run docker build to build out the images before pushing them.

And where would be the best place to define a securityContext on the build pod? Hard-coding it in lagoon-kbd would be one way.. but is that the best way to go?

The pod spec is defined in code, so adding the security context there would make sense. If it is a static config, if there are variables that need to be injected, we can still probably accomodate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants