Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSYS2 CMD Shell extensions in favor of separate MSystem project #7

Open
userzimmermann opened this issue Oct 7, 2016 · 12 comments
Assignees
Labels

Comments

@userzimmermann
Copy link
Owner

The included .bat scripts for managing and using MSYS2 directly in a CMD Shell are outdated and continued in my separate MSystem project:
https://github.com/zimmermanncode/MSystem

I will remove those old scripts before making a new Chocolatey MSYS2 release.

@userzimmermann userzimmermann self-assigned this Oct 7, 2016
@petemounce
Copy link
Contributor

If there is no harm in publishing an updated version to chocolatey, could I ask that you do that, and then this? I'd love to get a new version, since my bazel package has taken a dependency on msys2, and so that's blocked until there's a version that installs cleanly within the chocolatey automated validation check.

@rgl
Copy link

rgl commented Oct 8, 2016

FWIW, I'm manually building the msys2 package at https://github.com/rgl/visual-studio-community-vagrant/blob/master/provision.ps1#L292 (which is now kinda broken since the @petemounce branch that I was using does not exist anymore, but changing to the master branch of @userzimmermann works fine).

@petemounce
Copy link
Contributor

@rgl sorry about that; I deleted it once it was merged. I'm a fork, not the canonical; it didn't occur to me that someone might have taken a dependency on me.

@rgl
Copy link

rgl commented Oct 8, 2016

@petemounce ah no worries! I knew that it would eventually happen once your pull request was accepted :-)

@petemounce
Copy link
Contributor

@userzimmermann thinking about it - would it be possible to choco push each of the versions of msys2 that have happened since #3 was merged, so that users with a dependency on a particular release have those to choose from?

If it's a question of having time, if you'd be willing to allow me access to push the built package, I'd be more than willing to help.

@userzimmermann
Copy link
Owner Author

@petemounce Hi. I think so too. We should push all those versions starting from 20160719.0.1. The removal of the CMD shell stuff can wait ;) And yes, let's manage that package together on chocolatey.org! I will only make the same little change to the included msystem.bat for 20160719.0.1 like in 0a89c68 in a new separate msys2-20160719 branch and create the first release from there:
https://github.com/userzimmermann/choco-packages/commits/msys2-20160719
I have some more work to do now... let's continue this evening :)

@rgl Nice that you still use my package and everything works fine again :)

@petemounce
Copy link
Contributor

@userzimmermann thanks! On chocolatey.org, my username is petemounce as well.

@userzimmermann
Copy link
Owner Author

@petemounce @rgl BTW: I also upload my choco packages to https://www.myget.org/gallery/zimmermann-choco
Which might be easier to use as long as new packages on chocolatey.org are not approved yet.

And I also have my own CI tests for the msys2 package at https://ci.appveyor.com/project/userzimmermann/choco-packages-6hb62

@userzimmermann
Copy link
Owner Author

Officially released 20160719.1.0

https://chocolatey.org/packages/msys2/20160719.1.0
https://www.myget.org/feed/zimmermann-choco/package/nuget/msys2/20160719.1.0

@petemounce And I added you as msys2 maintainer on chotolatey.org

bazel-io pushed a commit to bazelbuild/bazel that referenced this issue Oct 11, 2016
Note - the chocolatey package to satisfy this has not yet been released, but it _will_ be according to [this trail](userzimmermann/choco-packages#7 (comment))

Closes #1905.

--
Reviewed-on: #1905
MOS_MIGRATED_REVID=135774603
@majkinetor
Copy link

I created a new version , please take a look:

chocolatey-community/chocolatey-packages#891

majkinetor added a commit to chocolatey-community/chocolatey-packages that referenced this issue Nov 4, 2017
@userzimmermann
Copy link
Owner Author

@majkinetor Nice! I should have reacted much earlier to all those requests regarding my msys2 package... Just too many projects ;)

@userzimmermann
Copy link
Owner Author

@majkinetor The work on my extensions also only very slowly progressed... But it's going on again now :) So I will release them separately with your new pure msys2 package as dependency soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants