Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Form legend + label: Duplicate styles #5894

Open
mahoneycm opened this issue Apr 26, 2024 · 0 comments
Open

USWDS - Form legend + label: Duplicate styles #5894

mahoneycm opened this issue Apr 26, 2024 · 0 comments
Assignees
Labels
Context: Sass Issue is in Sass Package: Forms Role: Dev Development/engineering skills needed

Comments

@mahoneycm
Copy link
Contributor

Description

usa-legend and usa-label class styles are duplicative. If we intend to maintain the same visual display for each we should consider moving these styles to a mixin so we only need to maintain in one location

Style definitions

usa-legend

.usa-legend {
@include typeset(
$theme-form-font-family,
$theme-body-font-size,
$theme-input-line-height
);
display: block;
font-weight: font-weight("normal");
margin-top: units(3);
max-width: units($theme-input-max-width);
}

usa-label

.usa-label {
@include typeset(
$theme-form-font-family,
$theme-body-font-size,
$theme-input-line-height
);
display: block;
font-weight: font-weight("normal");
margin-top: units(3);
max-width: units($theme-input-max-width);
}

@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Apr 26, 2024
@mejiaj mejiaj added Package: Forms Context: Sass Issue is in Sass Role: Dev Development/engineering skills needed and removed Status: Triage We're triaging this issue and grooming if necessary labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context: Sass Issue is in Sass Package: Forms Role: Dev Development/engineering skills needed
Projects
Status: Scheduled
Development

No branches or pull requests

2 participants