Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Bug: Version number appears twice on compile #5904

Open
2 tasks
mejiaj opened this issue Apr 30, 2024 · 0 comments
Open
2 tasks

USWDS - Bug: Version number appears twice on compile #5904

mejiaj opened this issue Apr 30, 2024 · 0 comments
Labels
Needs: Information The proposal is missing key information
Milestone

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Apr 30, 2024

The USWDS version number is appearing twice as a comment.

@charset "UTF-8";
/*! uswds v3.8.0 */
/*! uswds v3.8.0 */
/*! normalize.css v8.0.1 | MIT License | github.com/necolas/normalize.css */

Appears here in code:

/*! uswds @version */

/*! uswds @version */

Todo

  • Identify which is the most recommended file in guidance to determine which keeps the version.
  • Remove duplicate version comment.

Steps to reproduce

  1. Run npx gulp compileSass.
  2. Go to dist/css/uswds.css and/or minified version.
  3. Confirm duplicate version at the top.
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Apr 30, 2024
@brunerae brunerae added this to the uswds 3.9.1 milestone May 2, 2024
@brunerae brunerae added Needs: Information The proposal is missing key information and removed Status: Triage We're triaging this issue and grooming if necessary labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Information The proposal is missing key information
Projects
Status: No status
Development

No branches or pull requests

2 participants