Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Discord.js V13 #48

Closed
CarelessInternet opened this issue Jul 31, 2021 · 7 comments
Closed

Support for Discord.js V13 #48

CarelessInternet opened this issue Jul 31, 2021 · 7 comments
Assignees
Labels
dependencies This issue or pull request concerns a dependency
Milestone

Comments

@CarelessInternet
Copy link

Any plans for making this compatible with discord.js version 13 that is currently in development? When I try to react to the message, nothing happens.

@utarwyn
Copy link
Owner

utarwyn commented Jul 31, 2021

Hello! When discord.js v13 will be available as a stable release, I will add the support of course 👍
As this a development release for now, apart from specific cases or testing bots, I think it should not be used for production bots.

Do you need it in a near future? I don't know if we can support both versions easily.

@utarwyn utarwyn added dependencies This issue or pull request concerns a dependency status: help wanted Issues that need further investigation. labels Jul 31, 2021
@CarelessInternet
Copy link
Author

I would like to have it in the future, but I don't need it ASAP. I can wait until v13 becomes a stable release. I don't currently need support for v13, since production code is still written in v12. As for now, I have temporarily disabled the tic-tac-toe command for my bot's development for v13 of discord.js.

@utarwyn utarwyn mentioned this issue Aug 12, 2021
@utarwyn utarwyn added this to the 2.2.x milestone Aug 12, 2021
@utarwyn utarwyn pinned this issue Aug 14, 2021
@utarwyn
Copy link
Owner

utarwyn commented Aug 14, 2021

As the version 13 of discord.js is now out, I started to look into it. But I'm quite disappointed that it only supports Node 16+ which is not a LTS version. My module is intended to be easily installable and ready-to-use for all the community, so I can't make Node 16 mandatory for now. And I don't quite agree with the way the discord.js creators think.


Check the discussion about it on their repository: discordjs/discord.js#5119
And what nodejs.org says about releases on its website: https://nodejs.org/en/about/releases/

LTS release status is "long-term support", which typically guarantees that critical bugs will be fixed for a total of 30 months. Production applications should only use Active LTS or Maintenance LTS releases.


BUT I will try to add support for both v12 and v13 and fix the bug you mentionned.
AND I'm waiting for a feedback from the discord.js team or the release of Node 16 in LTS (end of 2021).

@utarwyn utarwyn added status: blocked Issues that are blocked for now. and removed status: help wanted Issues that need further investigation. labels Aug 14, 2021
@CarelessInternet
Copy link
Author

Ah okay, thanks for the update. I do want to mention one thing I forgot, in case you haven't added it in the prototype; I am listening to interaction events instead of message events, which means that you would have to take in account for both slash commands and/or regular messages.

@utarwyn
Copy link
Owner

utarwyn commented Aug 14, 2021

I have just wrote a new issue on this subject yes! Check it here: #56

@utarwyn
Copy link
Owner

utarwyn commented Oct 26, 2021

Hello! Node.js 16 is out as a LTS version! 👍
It means that I can start to work on a new release of the module which will work with discord.js 13+.

Here is how I have planned to handle module versionning:

  • The module will only support Node.js 16+ and discord.js 13+ from next version: its a breaking change so I have to create a new major version 3.x.x ;
  • I will also try to add same features in the current version 2.x during 3 months after v3 initial release ; and 3 more months for bugfixes if needed. End of life of v2 is planned for mid 2022.

This versionning schedule is temporary and may change according to user needs.

@utarwyn utarwyn removed the status: blocked Issues that are blocked for now. label Oct 26, 2021
@utarwyn utarwyn self-assigned this Oct 26, 2021
utarwyn added a commit that referenced this issue Oct 27, 2021
@utarwyn utarwyn modified the milestones: 2.2.x, 3.0.x Nov 22, 2021
@utarwyn utarwyn mentioned this issue Jan 23, 2022
@utarwyn
Copy link
Owner

utarwyn commented Feb 11, 2022

Version 3 of the module is now out with discord.js v13 support!
More info on the release here: https://github.com/utarwyn/discord-tictactoe/releases/tag/v3.0.0

@utarwyn utarwyn closed this as completed Feb 11, 2022
@utarwyn utarwyn unpinned this issue Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This issue or pull request concerns a dependency
Projects
None yet
Development

No branches or pull requests

2 participants