Adapt expiration message to game board delete configuration #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Kudos, SonarCloud Quality Gate passed!聽 聽 |
utarwyn
added
bug: confirmed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current version of the module, the game expiration message systematically replaces the message containing the game board. This is fine when you don't want to keep it, but illogical when you don't want to delete the game board (
gameBoardDeleteis false).So I propose to display the game expiration message in the same place as the winner, if any. It will be more consistent 馃憤
Here is a preview of how it will looks with
gameBoardDelete= true (like actual):Here is a preview of how it will looks with
gameBoardDelete= false:馃寕Closes #421
馃殌 Will be available from v3.x.