Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to display the player's emoji #537

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

utarwyn
Copy link
Owner

@utarwyn utarwyn commented Aug 4, 2023

Description

This PR creates a new option called gameBoardPlayerEmoji for displaying the player's emoji after its name in the gameboard state.

Here is a preview of how it will looks with gameBoardPlayerEmoji = false (current behavior):

image

Here is a preview of how it will looks with gameBoardPlayerEmoji = true:

image

馃寕Closes #436
馃殌 Will be available from v3.x.

@utarwyn utarwyn added type: enhancement Features and feature requests. status: testing Issues or PRs that need to be tested in order to be resolved. labels Aug 4, 2023
@utarwyn utarwyn added this to the 3.x milestone Aug 4, 2023
@utarwyn utarwyn self-assigned this Aug 4, 2023
@utarwyn utarwyn linked an issue Aug 4, 2023 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@utarwyn utarwyn removed the status: testing Issues or PRs that need to be tested in order to be resolved. label Aug 5, 2023
@utarwyn utarwyn merged commit a614a7e into release/3.x Aug 5, 2023
5 checks passed
@utarwyn utarwyn deleted the feature-436-emoji-state branch August 5, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player Emoji
1 participant