Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make deep require deprecation warning work in browsers #409

Merged
merged 1 commit into from Mar 31, 2020

Conversation

ctavan
Copy link
Member

@ctavan ctavan commented Mar 30, 2020

Relates to #408

I used Node.js' util.deprecate() in order to print deprecation warnings for deep requires. This obviously doesn't work in the browser. This can be solved by providing a manual warning fallback for the browser:

image

@ctavan ctavan requested review from broofa and LinusU March 30, 2020 15:40
@ctavan ctavan merged commit 4b71107 into master Mar 31, 2020
@ctavan ctavan deleted the fix-deprecation-for-browsers branch March 31, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants