Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainers should not be able to commit directly to master #590

Closed
broofa opened this issue Oct 26, 2021 · 7 comments
Closed

Maintainers should not be able to commit directly to master #590

broofa opened this issue Oct 26, 2021 · 7 comments
Labels
Projects
Milestone

Comments

@broofa
Copy link
Member

broofa commented Oct 26, 2021

I accidentally committed to master here. That sort of thing shouldn't be doable. master commits should only be the result of merging an approved PR.

@ctavan
Copy link
Member

ctavan commented Oct 26, 2021

The only issue with this right now is that we‘ll have to update our version bumping and release process which currently still relies on being able to push to master.

I never got around fixing that but I would also prefer to have master protected.

While we‘re at it we could also transition from master to main for a bit more inclusive language.

@broofa
Copy link
Member Author

broofa commented Oct 26, 2021

The only issue with this right now is that we‘ll have to update our version bumping and release process which currently still relies on being able to push to master.

Ah, right, I forgot about that. Maybe set up a workflow for this that takes care of things when a new release gets tagged? (Not sure how exactly that would work)

transition from master to main

Yes, please!

@broofa
Copy link
Member Author

broofa commented Oct 29, 2021

FWIW, I just renamed master to main. It mostly seems to be working. :-)

@broofa broofa added this to In progress in Version 9 Dec 1, 2021
@broofa broofa moved this from In progress to Discuss in Version 9 Dec 6, 2021
@ctavan ctavan added this to the 9.0.0 milestone Aug 3, 2022
@ctavan
Copy link
Member

ctavan commented Aug 12, 2022

I think we should be ready to enable branch protection for admins on main once we have #636 in place as we'll no longer need the commits that npm run release currently creates on main directly.

@github-actions
Copy link

Marking as stale due to 90 days with no activity.

@github-actions github-actions bot added the stale label Nov 11, 2022
@broofa broofa removed the stale label Nov 11, 2022
@github-actions
Copy link

Marking as stale due to 90 days with no activity.

@github-actions github-actions bot added the stale label Mar 22, 2023
@github-actions
Copy link

Closing issue due to 30 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Version 9
Up for Discussion
Development

No branches or pull requests

2 participants