You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all it took me a while to realize that the unflagging of --experimental-json-modules (nodejs/node#41736) has in fact not yet made it to the 16.x line of Node.js.
The problematic piece seems to be the import assertions that were added in 16.14.0.
In any case, the best thing I could come up with was extracting the package.json edge case into a separate test that is only run on node 16.x.
I would like to keep coverage of this edge case as it was a real world problem that we once fixed. At the same time I would like to keep esm tests running on Node.js 14 which also have stable support for them.
)
While ESM support has been stable in current versions of Node.js 14.x and 16.x, support for importing JSON files is still experimental and evolving.
Since we still want to cover the fact that the package is exporting it's package.json file, this test is now extracted to only run with the updated JSON import syntax which requires import assertions and which was introduced in Node.js 16.14.0.
Fixes#619
Co-authored-by: Robert Kieffer <robert@broofa.com>
@ctavan:
Care to comment (or, better, fix)?
The text was updated successfully, but these errors were encountered: