Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add max constant #714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add max constant #714

wants to merge 1 commit into from

Conversation

LinusU
Copy link
Member

@LinusU LinusU commented May 6, 2023

Fixes #685

Currently the validate function does not consider the MAX uuid as valid, maybe this is something we want to change in the next major version? 馃

@LinusU LinusU requested a review from broofa May 6, 2023 04:49
@LinusU LinusU mentioned this pull request May 6, 2023
Open
@broofa
Copy link
Member

broofa commented May 6, 2023

Let's make this part of the rfc4122bis branch (where all the new UUID features are being added).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexiaokang hexiaokang hexiaokang approved these changes

@broofa broofa Awaiting requested review from broofa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Max UUID as MAX constant
3 participants
@LinusU @broofa @hexiaokang