Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should schema2asp not be writing extent(F,MIN,MAX)? #93

Open
trubens71 opened this issue Aug 13, 2020 · 1 comment
Open

Should schema2asp not be writing extent(F,MIN,MAX)? #93

trubens71 opened this issue Aug 13, 2020 · 1 comment

Comments

@trubens71
Copy link

I note that schema2asp.ts is writing only field type and cardinality to the lp. Should it not also write MIN and MAX so that the 4 hard rules and 2 soft rules defined by "extent" come into play? I assume if it were to do so then the MIN/MAX values must be integers.

Same question for entropy but I think more complex as not in datalib summary stats.

@domoritz
Copy link
Member

Yes, that would be better. Draco doesn't need the extent but it's useful to have.

Could you send a pull request to add this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants