Fix outdated V8 Torque builtins #762

rluvaton · 2024-04-22T13:35:16Z

rluvaton · 2024-04-22T13:38:05Z

src/docs/torque-builtins.md

@@ -96,16 +97,23 @@ The definition is also straightforward. The only difference to our builtin with

 ```torque
 namespace math {
-  builtin HeapNumberIs42(implicit context: Context)(heapNumber: HeapNumber):
-      Boolean {
+  transitioning macro HeapNumberIs42(implicit context: Context)(heapNumber: HeapNumber): Boolean {


Lines 95-97 should be updated as well but I'm not sure what to write there

rluvaton · 2024-04-22T13:39:10Z

src/docs/torque-builtins.md

@@ -132,7 +131,7 @@ TEST(MathIsHeapNumber42) {
  Heap* heap = isolate->heap();
  Zone* zone = scope.main_zone();

-  StubTester tester(isolate, zone, Builtins::kMathIs42);
+  StubTester tester(isolate, zone, Builtin::kMathIs42);


Line 126 should be updated as well, there is no more test-run-stubs.cc file

rluvaton added 2 commits April 22, 2024 16:35

Fix outdated V8 Torque builtins

bd80f27

Update torque-builtins.md

9f2ee8a

rluvaton commented Apr 22, 2024

View reviewed changes

Update torque-builtins.md

eb3aa11

rluvaton commented Apr 22, 2024

View reviewed changes

Update torque-builtins.md

6e3e0f4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix outdated V8 Torque builtins #762

Fix outdated V8 Torque builtins #762

rluvaton commented Apr 22, 2024

rluvaton Apr 22, 2024 •

edited

rluvaton Apr 22, 2024 •

edited

Fix outdated V8 Torque builtins #762

Are you sure you want to change the base?

Fix outdated V8 Torque builtins #762

Conversation

rluvaton commented Apr 22, 2024

rluvaton Apr 22, 2024 • edited

Choose a reason for hiding this comment

rluvaton Apr 22, 2024 • edited

Choose a reason for hiding this comment

rluvaton Apr 22, 2024 •

edited

rluvaton Apr 22, 2024 •

edited