Skip to content

Commit

Permalink
fix overflow check in error formatting
Browse files Browse the repository at this point in the history
Bug: v8:12494
Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Gus Caplan <snek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78909}
  • Loading branch information
devsnek authored and V8 LUCI CQ committed Feb 2, 2022
1 parent 10e811c commit cc9a8a3
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/execution/messages.cc
Expand Up @@ -305,7 +305,8 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
const bool in_recursion = isolate->formatting_stack_trace();
const bool has_overflowed = i::StackLimitCheck{isolate}.HasOverflowed();
Handle<Context> error_context;
if (!in_recursion && error->GetCreationContext().ToHandle(&error_context)) {
if (!in_recursion && !has_overflowed &&
error->GetCreationContext().ToHandle(&error_context)) {
DCHECK(error_context->IsNativeContext());

if (isolate->HasPrepareStackTraceCallback()) {
Expand All @@ -321,7 +322,7 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
isolate->RunPrepareStackTraceCallback(error_context, error, sites),
Object);
return result;
} else if (!has_overflowed) {
} else {
Handle<JSFunction> global_error =
handle(error_context->error_function(), isolate);

Expand Down

0 comments on commit cc9a8a3

Please sign in to comment.