Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mocha benchmark #66

Open
mathiasbynens opened this issue Feb 25, 2019 · 3 comments
Open

Add Mocha benchmark #66

mathiasbynens opened this issue Feb 25, 2019 · 3 comments

Comments

@mathiasbynens
Copy link
Member

Specifically, Mocha seems to perform lots of operations like Array#includes and Array#indexOf on frozen arrays while setting up its environment and executing its tests.

It would be good to have this pattern reflected in the WTB.

Ref. https://docs.google.com/document/d/1X6zO5F_Zojizn2dmo_ftaOWsY8NltPHUhudBbUzMxnc/edit.

@robpalme
Copy link

@mathiasbynens Are you looking to solve this by adding a specific Mocha benchmark (as the title says) or would you accept a more focused benchmark (derived from Mocha's actions) that specifically targeted operations on frozen arrays?

@mathiasbynens
Copy link
Member Author

Ideally, we'd add a benchmark that exercises the relevant parts of Mocha.

We're specifically not looking for microbenchmarks (since those don't reflect real-world performance).

@robpalme
Copy link

robpalme commented Feb 27, 2019

@mathiasbynens We have two volunteers (Damola and Yilang) that want to pair on this. Will be in touch for next steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants