Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Flow doesn't bring in deprecated frontend libraries #13133

Closed
tarekoraby opened this issue Feb 23, 2022 · 3 comments · Fixed by #13146
Closed

Ensure that Flow doesn't bring in deprecated frontend libraries #13133

tarekoraby opened this issue Feb 23, 2022 · 3 comments · Fixed by #13146

Comments

@tarekoraby
Copy link
Contributor

Describe your motivation

Today a 23 beta3 project shows npm deprecation warnings for source-map-url, urix, source-map-resolve, chokidar, resolve-url, querystring, core-js, which yields a bad DX (especially for new evaluators).

Describe the solution you'd like

A Flow project should not bring in any deprecated frontend library.

Describe alternatives you've considered

An alternative would be to hide the npm warnings from the logs (as in #13129). However, as @knoobie rightly notes, that would constitute an act of sweeping the dirt under the rug.

Additional context

Vite projects seem to only generate a single deprecation warning for source-map-url.

@Artur-
Copy link
Member

Artur- commented Feb 23, 2022

GoogleChrome/workbox#3031 will resolve source-map-url for Vite

Artur- added a commit that referenced this issue Feb 24, 2022
Artur- added a commit that referenced this issue Feb 24, 2022
joheriks pushed a commit that referenced this issue Mar 2, 2022
vaadin-bot pushed a commit that referenced this issue Mar 2, 2022
@knoobie
Copy link
Contributor

knoobie commented Mar 2, 2022

I don't think this issue should be closed just for vite - or does this update fixes all warnings for webpack as well?

@Artur-
Copy link
Member

Artur- commented Mar 2, 2022

The only solution for webpack would be to upgrade to webpack 5. This would be a breaking change for some people and have very little value as we are moving to Vite.

joheriks pushed a commit that referenced this issue Mar 2, 2022
Resolves #13133 for Vite

Co-authored-by: Artur <artur@vaadin.com>
mstahv pushed a commit that referenced this issue Mar 9, 2022
mstahv pushed a commit that referenced this issue Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants