Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LineAwesome icon set up by start.vaadin.com is not displayed if the folder name contains a space #13203

Closed
mstahv opened this issue Mar 4, 2022 · 7 comments
Closed

LineAwesome icon set up by start.vaadin.com is not displayed if the folder name contains a space #13203

mstahv opened this issue Mar 4, 2022 · 7 comments
Assignees
@Artur-
Labels
vite Tickets related to vite support
Projects
OLD Vaadin Flow bugs & maintenance (V...

Comments

@mstahv
Copy link
Member

mstahv commented Mar 4, 2022

Download a project from start.vaadin.com with vite enabled. When you run the project, the icons in the menu are not displayed.

  • Mac
  • 23.0.0
  • Java 17
  • Any browser
@mstahv mstahv added the vite Tickets related to vite support label Mar 4, 2022
@Artur-
Copy link
Member

Artur- commented Mar 4, 2022

This one is a bit curious because I have also seen it and the icons are not displayed because the line awesome font is not loaded. But right now I cannot reproduce it

@tarekoraby
Copy link
Contributor

Reproduced with Hilla 1.0.2 on Windows.

@Artur- Artur- changed the title LineAwesome icon set up by start.vaadin.com is not displayed LineAwesome icon set up by start.vaadin.com is not displayed if the folder name contains a space Mar 25, 2022
@Artur-
Copy link
Member

Artur- commented Mar 25, 2022

Reproduces when the folder name contains a space. Seems like CSS import urls are not encoded by Vite

@Artur- Artur- self-assigned this Mar 25, 2022
@Artur-
Copy link
Member

Artur- commented Mar 25, 2022

vitejs/vite#7452

@tarekoraby
Copy link
Contributor

And for the record, the icons work in production builds (using mvn -Pproduction).

@Artur-
Copy link
Member

Artur- commented Mar 29, 2022

Additionally requires vitejs/vite#7510

@Artur-
Copy link
Member

Artur- commented Mar 31, 2022

Fixed in #13399

@Artur- Artur- closed this as completed Mar 31, 2022
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from Needs triage to Closed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Artur- Artur-

Labels
vite Tickets related to vite support
Projects
OLD Vaadin Flow bugs & maintenance (V...
Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Artur- @mstahv @tarekoraby