New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: observe tabs ID attribute changes and update panels #7201
Conversation
6f0304b
to
08ae50d
Compare
Quality Gate passedIssues Measures |
Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually? |
This ticket/PR has been released with Vaadin 24.4.0.alpha17 and is also targeting the upcoming stable 24.4.0 version. |
Description
Fixes vaadin/flow-components#6072
Here's the code example to reproduce the issue and test the fix:
Put this to dev page and try to set
id
on the firstvaadin-tab
totab-1
.Type of change
Note
Initially, I was thinking about adding a warning for
vaadin-tab
elements withoutid
attribute set. However, Flow does not setid
attribute when usingsetVisible(false)
and it's by design, so in this case the warning would be redundant.This fix can be also considered as "feature", as it also adds an option to un-link tab with panel by setting
id
tonull
.