fix: focus first non-disabled item if all items have tabindex -1 #7230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Mar 18, 2024
vursen
reviewed
Mar 19, 2024
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
vursen
approved these changes
Mar 19, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
web-padawan
added a commit
that referenced
this pull request
Mar 19, 2024
…) (#7239) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
|
This ticket/PR has been released with Vaadin 24.4.0.alpha17 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7228
The logic in
focus()method ofListMixinis problematic since it focuses first item without checking if it's disabled.Updated to use logic from
KeyboardDirectionMixinand addedvaadin-context-menuandvaadin-menu-bartests.Type of change
Note
Setting
tabindexto-1on all the items is done since #7203 which was a fix for #7202. While that issue could be fixed in a different way, IMO the approach used in this PR was correct. The current PR should be a proper fix for #7142.