fix: fire change event on hyperlink edit, update test timings #7250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7249
When adding link, the
change
event was not fired byvaadin-rich-text-editor
. Here's what happened:this._editor.format('link', link, SOURCE.USER)
,focus
event listener calls_cleanToolbarState()
immediately,value
change observer, no change event due to the toolbar in "default" state.Added a check for
_linkEditing
(which corresponds to the link dialogopened
property) as a fix.Note: when removing the
focus
listener completely, all the tests still pass onmain
branch 🙈Type of change