Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't replicate SETSLOT to nodes that may crash #421

Open
zuiderkwast opened this issue May 2, 2024 · 0 comments
Open

Don't replicate SETSLOT to nodes that may crash #421

zuiderkwast opened this issue May 2, 2024 · 0 comments

Comments

@zuiderkwast
Copy link
Contributor

#245 replicates CLUSTER SETSLOT. Old replicas would generate an error reply for this. They would even panic if 'propagation-error-behaviour' config is set to 'panic'.

To prevent that, use a flag in clusterMsg as a capability flag to indicate support for this feature. If the replica doesn't have this flag set, we don't replicate SETSLOT to it.

It'd be similar to the flag CLUSTER_NODE_EXTENSIONS_SUPPORTED.

Originally discussed here: #245 (comment)_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant