Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Playwright #6590

Merged

Conversation

leonidlosyukov
Copy link
Contributor

@leonidlosyukov leonidlosyukov commented Jun 29, 2023

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@leonidlosyukov leonidlosyukov marked this pull request as draft June 29, 2023 09:39
@leonidlosyukov leonidlosyukov marked this pull request as ready for review July 4, 2023 12:14
README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #6590 (ab15cca) into development (6cd3af3) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head ab15cca differs from pull request most recent head 7a5c1de. Consider uploading reports for the commit 7a5c1de to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6590      +/-   ##
===============================================
- Coverage        76.97%   76.91%   -0.06%     
===============================================
  Files              315      315              
  Lines            10719    10719              
  Branches          2993     3102     +109     
===============================================
- Hits              8251     8245       -6     
- Misses            2466     2472       +6     
  Partials             2        2              

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd3af3...7a5c1de. Read the comment docs.

@valorkin valorkin merged commit e2958bf into valor-software:development Jul 7, 2023
10 checks passed
@hansireit
Copy link

@valorkin @leonidlosyukov Because of this PR some documentations in ng-api-doc.ts are now missing.
e.g.: #6610
Was this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants