-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for issue 6596 #6599
fix for issue 6596 #6599
Conversation
@valorkin @SvetlanaMuravlova Request you to take a look at this. |
looks good to me, I will publish when CI is done, thanks |
@valorkin Do you know why CI failed? |
just FYI es2022 changes default settings for useDefineForClassFields |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #6599 +/- ##
===============================================
- Coverage 76.85% 76.83% -0.02%
===============================================
Files 315 315
Lines 10682 10682
Branches 2853 2853
===============================================
- Hits 8210 8208 -2
- Misses 2471 2473 +2
Partials 1 1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.