Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue 6596 #6599

Merged
merged 3 commits into from
Jul 13, 2023
Merged

fix for issue 6596 #6599

merged 3 commits into from
Jul 13, 2023

Conversation

MPruntel
Copy link
Contributor

@MPruntel MPruntel commented Jul 12, 2023

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@swapnil0545
Copy link

@valorkin @SvetlanaMuravlova Request you to take a look at this.

valorkin
valorkin previously approved these changes Jul 13, 2023
@valorkin
Copy link
Member

looks good to me, I will publish when CI is done, thanks

@MPruntel
Copy link
Contributor Author

@valorkin Do you know why CI failed?

@valorkin
Copy link
Member

just FYI es2022 changes default settings for useDefineForClassFields

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #6599 (e115882) into development (6132a7c) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head e115882 differs from pull request most recent head 3dbd062. Consider uploading reports for the commit 3dbd062 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6599      +/-   ##
===============================================
- Coverage        76.85%   76.83%   -0.02%     
===============================================
  Files              315      315              
  Lines            10682    10682              
  Branches          2853     2853              
===============================================
- Hits              8210     8208       -2     
- Misses            2471     2473       +2     
  Partials             1        1              

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6132a7c...3dbd062. Read the comment docs.

@valorkin valorkin merged commit cc5d58d into valor-software:development Jul 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants