Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More OAuth Providers #2

Open
2 of 4 tasks
calebkleveter opened this issue Nov 13, 2017 · 11 comments
Open
2 of 4 tasks

Add More OAuth Providers #2

calebkleveter opened this issue Nov 13, 2017 · 11 comments

Comments

@calebkleveter
Copy link
Member

calebkleveter commented Nov 13, 2017

GitHub makes a good start for supported OAuth providers, but we need more. Below are a few I would like to add:

  • Twitter
  • Google
  • Facebook
  • Instagram

or any others that we think would be good.

Note to maintainer: Look into Auth0

@kdawgwilk
Copy link

Wouldn't Auth0 be a great option since they can then be a proxy for other providers like the ones above?

@calebkleveter
Copy link
Member Author

I have never really looked into Auth0 all that much. I'll add a reminder to the issue 👍.

@maldahleh
Copy link

Is there a chance we can get Uber support?

@calebkleveter
Copy link
Member Author

@maldahleh That sounds like a great idea, but I am relying on other people's contributions for certain services, meaning I have no timeframe as to when that would get added. If you want to contribute, that would be great, if not, no sweat 🙂.

@natebird
Copy link
Contributor

natebird commented Jan 21, 2019

@calebkleveter I'm implementing Facebook and Twitter logins for my app. I'll get some prototype code working with Github first, to get an idea of how this all fits together, and then I'll take a stab at Facebook and then Twitter.

Question: What is the architectural reason for including each provider in the main library? Other similar libraries like OmniAuth have a core library and then you can use the specific provider needed.

@0xTim
Copy link
Member

0xTim commented Jan 21, 2019

@natebird see #19 for a Facebook integration - I think it works. As for the second question, see #24 !

@natebird
Copy link
Contributor

@0xTim - great! I'm trying out the Facebook integration now. I'll let you know if it actually works. :-P

@calebkleveter
Copy link
Member Author

@natebird If it works (or you get it working) and you happen to have time to throw together a getting started guide so we can merge #19, that would be great! If not, it won't hurt to sit around a bit longer 😄

@natebird
Copy link
Contributor

I pushed up a starter guide for Facebook integration to #19. I have a working implementation in development using SSL.

@gaetandezeiraud
Copy link
Contributor

Keycloak support is planned?

@rafiki270
Copy link
Collaborator

@Brouilles I don’t think it is but please send a PR if you do it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants