New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/apple/swift-nio-http2 #1
Comments
Right, it is available, however, Vapor needs to app support for it before this library can take advantage of it. Tanner did mention that once Fluent is released, he was going to looking into this. |
Any news? |
Nothing yet. The moment it does get support for HTTP/2 I'll be able to implement this. |
Sounds like we may not need Vapor to be http2 |
FWIW, I've got this working with Swift NIO HTTP2 directly as suggested. |
@kylebrowning is that work open source? If so, you should consider submitting it to the Swift Server Work Group. :) https://forums.swift.org/c/server/pitches |
@tanner0101 I don't mind open sourcing it, im just working on the JSON Web Token stuff and trying to use as little dependencies as possible, if any at all. |
@tanner0101 alas ive come full circle to this, vapor/open-crypto#73 Ill try to get it working myself without deps, but its been a whirlwind. |
@kylebrowning I agree, it would be great if the APNS package did not need to depend on You could also just import |
https://github.com/ethanhuang13/CupertinoJWT @tanner0101 this does it without any deps. May integrate the same way. |
Wrong. It depends on the CommonCrypto framework, which is not available on Linux. |
Doh. Thanks. |
@vzsg does using |
@kylebrowning I think that's part of the |
Okay so last night I got this working over here, https://github.com/moritzsternemann/nio-apns/tree/kyle-develop It only depends on OpenSSL. The other NIOH2 package it is importing is simply an HTTP2 client. Relevant code is here and here So the question remains now. Do we want to require an HTTP2 NIO client like the one Ive just required and submitted a pr to? Tanner suggested we work on the pitch to server working group for a standardized HTTP1/2 client but with my open source experience I know that will take some time. I slightly like the architecture/structure of the other apns library so Im inclined to go work over there especially since it is not dependent on vapor. Im more inclined to build a Push Notification vapor library that allows Android or iOS devices to pub sub and stores all that inside of vapor. Then vapor just calls the NIO HTTP2 to push notifications. Im going to start that route and just leave the shared code here for others if they want to go different ways Once the standard HTTP1/2 client is finished, then we can port to that and drop the support for the custom HTTP2 client. |
FYI. Ive moved this work over to, https://github.com/kylebrowning/swift-nio-http2-apns and submitted a pitch here. https://forums.swift.org/t/apple-push-notification-service-implementation-pitch/20193 |
The http2 library seems to be ready to use.
The text was updated successfully, but these errors were encountered: