Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t do storage in this package #2

Open
mxcl opened this issue Nov 14, 2018 · 1 comment
Open

Don’t do storage in this package #2

mxcl opened this issue Nov 14, 2018 · 1 comment

Comments

@mxcl
Copy link

mxcl commented Nov 14, 2018

From vapor/vapor#1650

You said:

Off topic from this thread but I guess the idea is, since there's no DB storage in NIO. Id need to support the storage and registration of subscriptions/devices inside of Vapor (ie the device id's, and channels) and then setup something separate on Swift-NIO that actually communicates with Apple, but my Vapor App communicates with the NIO stack?

I don't think you should do storage or database work here, that's up to the consumer. Just my 2¢, but it seems outside the boundaries of the purpose of this part of the stack. The consumer of this package will want to choose how such things are stored themselves.

@tanner0101
Copy link

I agree. IMO this package can and should depend solely on SwiftNIO. Anything else needed for APNS should be defined as structs or protocols that the user can supply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants