Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async example to use runIfActive instead of submit #478

Merged
merged 1 commit into from Apr 30, 2020
Merged

Fix async example to use runIfActive instead of submit #478

merged 1 commit into from Apr 30, 2020

Conversation

finestructure
Copy link
Sponsor Member

As discussed here: https://discordapp.com/channels/431917998102675485/444249946808647699/705452538438221845

@jw advises not to use submit:

don't use submit really. It calls you back with .cancelled if the thread pool is already torn down

https://discordapp.com/channels/431917998102675485/444249946808647699/705420024592072765

@0xTim
Copy link
Member

0xTim commented Apr 30, 2020

We'll need to update the async password hasher to use this new method as well, I'll get around to that tomorrow and then merge this PR

@jdmcd
Copy link
Member

jdmcd commented Apr 30, 2020

@0xTim I can knock this out today, if you'd like.

@jdmcd jdmcd mentioned this pull request Apr 30, 2020
Merged
@jdmcd
Copy link
Member

jdmcd commented Apr 30, 2020 •
edited

@0xTim PR here: vapor/vapor#2340

0xTim
0xTim approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit b44ef1a into vapor:master Apr 30, 2020
@tanner0101 tanner0101 added the updates Adding new or updated documentation. label Apr 30, 2020
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Apr 30, 2020
@tanner0101 tanner0101 moved this from Awaiting Review to Done in Vapor 4 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@tanner0101 tanner0101 Awaiting requested review from tanner0101

Assignees
No one assigned
Labels
updates Adding new or updated documentation.
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@finestructure @0xTim @jdmcd @tanner0101